Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 333595
b: refs/heads/master
c: 3c2995a
h: refs/heads/master
i:
  333593: de22c3a
  333591: c61e5c7
v: v3
  • Loading branch information
Archit Taneja authored and Tomi Valkeinen committed Sep 26, 2012
1 parent bacbddb commit d5cfd2d
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 72 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 0f0e4e3cd8030c3056e8f43196a112e887a545f9
refs/heads/master: 3c2995ac34eb559106504be962b162aef215895b
64 changes: 0 additions & 64 deletions trunk/drivers/video/omap2/dss/apply.c
Original file line number Diff line number Diff line change
Expand Up @@ -1110,70 +1110,6 @@ void dss_mgr_get_info(struct omap_overlay_manager *mgr,
spin_unlock_irqrestore(&data_lock, flags);
}

int dss_mgr_set_device(struct omap_overlay_manager *mgr,
struct omap_dss_device *dssdev)
{
int r;

mutex_lock(&apply_lock);

if (dssdev->manager) {
DSSERR("display '%s' already has a manager '%s'\n",
dssdev->name, dssdev->manager->name);
r = -EINVAL;
goto err;
}

if ((mgr->supported_displays & dssdev->type) == 0) {
DSSERR("display '%s' does not support manager '%s'\n",
dssdev->name, mgr->name);
r = -EINVAL;
goto err;
}

dssdev->manager = mgr;
mgr->device = dssdev;

mutex_unlock(&apply_lock);

return 0;
err:
mutex_unlock(&apply_lock);
return r;
}

int dss_mgr_unset_device(struct omap_overlay_manager *mgr)
{
int r;

mutex_lock(&apply_lock);

if (!mgr->device) {
DSSERR("failed to unset display, display not set.\n");
r = -EINVAL;
goto err;
}

/*
* Don't allow currently enabled displays to have the overlay manager
* pulled out from underneath them
*/
if (mgr->device->state != OMAP_DSS_DISPLAY_DISABLED) {
r = -EINVAL;
goto err;
}

mgr->device->manager = NULL;
mgr->device = NULL;

mutex_unlock(&apply_lock);

return 0;
err:
mutex_unlock(&apply_lock);
return r;
}

int dss_mgr_set_output(struct omap_overlay_manager *mgr,
struct omap_dss_output *output)
{
Expand Down
2 changes: 0 additions & 2 deletions trunk/drivers/video/omap2/dss/manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ int dss_init_overlay_managers(struct platform_device *pdev)
break;
}

mgr->set_device = &dss_mgr_set_device;
mgr->unset_device = &dss_mgr_unset_device;
mgr->set_output = &dss_mgr_set_output;
mgr->unset_output = &dss_mgr_unset_output;
mgr->apply = &omap_dss_mgr_apply;
Expand Down
5 changes: 0 additions & 5 deletions trunk/include/video/omapdss.h
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,6 @@ struct omap_overlay_manager {
enum omap_dss_output_id supported_outputs;

/* dynamic fields */
struct omap_dss_device *device;
struct omap_dss_output *output;

/*
Expand All @@ -478,9 +477,6 @@ struct omap_overlay_manager {
* interrupt context
*/

int (*set_device)(struct omap_overlay_manager *mgr,
struct omap_dss_device *dssdev);
int (*unset_device)(struct omap_overlay_manager *mgr);
int (*set_output)(struct omap_overlay_manager *mgr,
struct omap_dss_output *output);
int (*unset_output)(struct omap_overlay_manager *mgr);
Expand Down Expand Up @@ -628,7 +624,6 @@ struct omap_dss_device {

enum omap_display_caps caps;

struct omap_overlay_manager *manager;
struct omap_dss_output *output;

enum omap_dss_display_state state;
Expand Down

0 comments on commit d5cfd2d

Please sign in to comment.