Skip to content

Commit

Permalink
sched: convert sched_domain_debug to cpumask_var_t.
Browse files Browse the repository at this point in the history
Impact: stack usage reduction

Dynamically allocating cpumasks (when CONFIG_CPUMASK_OFFSTACK) saves
stack space.  cpumask_var_t is just a struct cpumask for
!CONFIG_CPUMASK_OFFSTACK.

In this case, we always alloced, but we don't need to any more.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Rusty Russell authored and Ingo Molnar committed Nov 24, 2008
1 parent 5a16f3d commit d5dd3db
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -6706,7 +6706,7 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,

static void sched_domain_debug(struct sched_domain *sd, int cpu)
{
cpumask_t *groupmask;
cpumask_var_t groupmask;
int level = 0;

if (!sd) {
Expand All @@ -6716,8 +6716,7 @@ static void sched_domain_debug(struct sched_domain *sd, int cpu)

printk(KERN_DEBUG "CPU%d attaching sched-domain:\n", cpu);

groupmask = kmalloc(sizeof(cpumask_t), GFP_KERNEL);
if (!groupmask) {
if (!alloc_cpumask_var(&groupmask, GFP_KERNEL)) {
printk(KERN_DEBUG "Cannot load-balance (out of memory)\n");
return;
}
Expand All @@ -6730,7 +6729,7 @@ static void sched_domain_debug(struct sched_domain *sd, int cpu)
if (!sd)
break;
}
kfree(groupmask);
free_cpumask_var(groupmask);
}
#else /* !CONFIG_SCHED_DEBUG */
# define sched_domain_debug(sd, cpu) do { } while (0)
Expand Down

0 comments on commit d5dd3db

Please sign in to comment.