Skip to content

Commit

Permalink
USB: resume_device symbol conflict
Browse files Browse the repository at this point in the history
Several functions in USB core overlap with global functions.
The linker appears to do the right thing, but it is bad practice and makes
debugging harder.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Stephen Hemminger authored and Greg Kroah-Hartman committed Dec 1, 2006
1 parent d8126a0 commit d5ec168
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions drivers/usb/core/driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -810,7 +810,7 @@ EXPORT_SYMBOL_GPL_FUTURE(usb_deregister);
#ifdef CONFIG_PM

/* Caller has locked udev's pm_mutex */
static int suspend_device(struct usb_device *udev, pm_message_t msg)
static int usb_suspend_device(struct usb_device *udev, pm_message_t msg)
{
struct usb_device_driver *udriver;
int status = 0;
Expand All @@ -837,7 +837,7 @@ static int suspend_device(struct usb_device *udev, pm_message_t msg)
}

/* Caller has locked udev's pm_mutex */
static int resume_device(struct usb_device *udev)
static int usb_resume_device(struct usb_device *udev)
{
struct usb_device_driver *udriver;
int status = 0;
Expand All @@ -863,7 +863,7 @@ static int resume_device(struct usb_device *udev)
}

/* Caller has locked intf's usb_device's pm mutex */
static int suspend_interface(struct usb_interface *intf, pm_message_t msg)
static int usb_suspend_interface(struct usb_interface *intf, pm_message_t msg)
{
struct usb_driver *driver;
int status = 0;
Expand Down Expand Up @@ -900,7 +900,7 @@ static int suspend_interface(struct usb_interface *intf, pm_message_t msg)
}

/* Caller has locked intf's usb_device's pm_mutex */
static int resume_interface(struct usb_interface *intf)
static int usb_resume_interface(struct usb_interface *intf)
{
struct usb_driver *driver;
int status = 0;
Expand Down Expand Up @@ -1031,19 +1031,19 @@ int usb_suspend_both(struct usb_device *udev, pm_message_t msg)
if (udev->actconfig) {
for (; i < udev->actconfig->desc.bNumInterfaces; i++) {
intf = udev->actconfig->interface[i];
status = suspend_interface(intf, msg);
status = usb_suspend_interface(intf, msg);
if (status != 0)
break;
}
}
if (status == 0)
status = suspend_device(udev, msg);
status = usb_suspend_device(udev, msg);

/* If the suspend failed, resume interfaces that did get suspended */
if (status != 0) {
while (--i >= 0) {
intf = udev->actconfig->interface[i];
resume_interface(intf);
usb_resume_interface(intf);
}

/* If the suspend succeeded, propagate it up the tree */
Expand Down Expand Up @@ -1109,22 +1109,22 @@ int usb_resume_both(struct usb_device *udev)
status = -EHOSTUNREACH;
}
if (status == 0)
status = resume_device(udev);
status = usb_resume_device(udev);
if (parent)
usb_pm_unlock(parent);
} else {

/* Needed only for setting udev->dev.power.power_state.event
* and for possible debugging message. */
status = resume_device(udev);
status = usb_resume_device(udev);
}

/* Now the parent won't suspend until we are finished */

if (status == 0 && udev->actconfig) {
for (i = 0; i < udev->actconfig->desc.bNumInterfaces; i++) {
intf = udev->actconfig->interface[i];
resume_interface(intf);
usb_resume_interface(intf);
}
}

Expand Down

0 comments on commit d5ec168

Please sign in to comment.