Skip to content

Commit

Permalink
lcs: ODEBUG: object is on stack, but not annotated.
Browse files Browse the repository at this point in the history
Timer_list structure in lcs_send_lancmd() is allocated on stack.
Initialization with init_timer() leads to above ODEBUG message.
Instead use init_timer_on_stack() which prevents above msg.

Signed-off-by: Klaus-Dieter Wacker <kdwacker@de.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Klaus-Dieter Wacker authored and David S. Miller committed Oct 18, 2009
1 parent 9a4ff8d commit d62e09e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/s390/net/lcs.c
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ lcs_send_lancmd(struct lcs_card *card, struct lcs_buffer *buffer,
rc = lcs_ready_buffer(&card->write, buffer);
if (rc)
return rc;
init_timer(&timer);
init_timer_on_stack(&timer);
timer.function = lcs_lancmd_timeout;
timer.data = (unsigned long) reply;
timer.expires = jiffies + HZ*card->lancmd_timeout;
Expand Down

0 comments on commit d62e09e

Please sign in to comment.