Skip to content

Commit

Permalink
drivers/video/savage/savagefb_driver.c: fix error return code
Browse files Browse the repository at this point in the history
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
  • Loading branch information
Peter Senna Tschudin authored and Florian Tobias Schandinat committed Oct 10, 2012
1 parent 5ce2497 commit d63f2c5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/video/savage/savagefb_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -2266,8 +2266,10 @@ static int __devinit savagefb_probe(struct pci_dev* dev,
lpitch = info->var.xres_virtual*((info->var.bits_per_pixel + 7) >> 3);
info->var.yres_virtual = info->fix.smem_len/lpitch;

if (info->var.yres_virtual < info->var.yres)
if (info->var.yres_virtual < info->var.yres) {
err = -ENOMEM;
goto failed;
}

#if defined(CONFIG_FB_SAVAGE_ACCEL)
/*
Expand Down

0 comments on commit d63f2c5

Please sign in to comment.