Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 179403
b: refs/heads/master
c: 6d12552
h: refs/heads/master
i:
  179401: d361a0a
  179399: 2aa6c1a
v: v3
  • Loading branch information
Al Viro committed Jan 14, 2010
1 parent 4c3464a commit d64970c
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 9 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 4ecf09fd3a7c8858198875171b684c73338fad83
refs/heads/master: 6d125529c6cbfe570ce3bf9a0728548f087499da
2 changes: 1 addition & 1 deletion trunk/fs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,7 @@ struct file *do_filp_open(int dfd, const char *pathname,
open_flag |= O_DSYNC;

if (!acc_mode)
acc_mode = MAY_OPEN | ACC_MODE(flag);
acc_mode = MAY_OPEN | ACC_MODE(open_flag);

/* O_TRUNC implies we need access checks for write permissions */
if (flag & O_TRUNC)
Expand Down
2 changes: 1 addition & 1 deletion trunk/include/linux/fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -2463,7 +2463,7 @@ int proc_nr_files(struct ctl_table *table, int write,

int __init get_filesystem_list(char *buf);

#define ACC_MODE(x) ("\000\004\002\006"[(x)&O_ACCMODE])
#define ACC_MODE(x) ("\004\002\006\006"[(x)&O_ACCMODE])
#define OPEN_FMODE(flag) ((__force fmode_t)((flag + 1) & O_ACCMODE))

#endif /* __KERNEL__ */
Expand Down
7 changes: 1 addition & 6 deletions trunk/security/tomoyo/tomoyo.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,8 @@ static int tomoyo_bprm_check_security(struct linux_binprm *bprm)
return tomoyo_find_next_domain(bprm);
/*
* Read permission is checked against interpreters using next domain.
* '1' is the result of open_to_namei_flags(O_RDONLY).
*/
return tomoyo_check_open_permission(domain, &bprm->file->f_path, 1);
return tomoyo_check_open_permission(domain, &bprm->file->f_path, O_RDONLY);
}

static int tomoyo_path_truncate(struct path *path, loff_t length,
Expand Down Expand Up @@ -184,10 +183,6 @@ static int tomoyo_file_fcntl(struct file *file, unsigned int cmd,
static int tomoyo_dentry_open(struct file *f, const struct cred *cred)
{
int flags = f->f_flags;

if ((flags + 1) & O_ACCMODE)
flags++;
flags |= f->f_flags & (O_APPEND | O_TRUNC);
/* Don't check read permission here if called from do_execve(). */
if (current->in_execve)
return 0;
Expand Down

0 comments on commit d64970c

Please sign in to comment.