Skip to content

Commit

Permalink
NFC: Move the nfcwilink dereference below the NULL test
Browse files Browse the repository at this point in the history
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Wei Yongjun authored and Samuel Ortiz committed Sep 24, 2012
1 parent f4f20d0 commit d6650a2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/nfc/nfcwilink.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,6 @@ static long nfcwilink_receive(void *priv_data, struct sk_buff *skb)
struct nfcwilink *drv = priv_data;
int rc;

nfc_dev_dbg(&drv->pdev->dev, "receive entry, len %d", skb->len);

if (!skb)
return -EFAULT;

Expand All @@ -362,6 +360,8 @@ static long nfcwilink_receive(void *priv_data, struct sk_buff *skb)
return -EFAULT;
}

nfc_dev_dbg(&drv->pdev->dev, "receive entry, len %d", skb->len);

/* strip the ST header
(apart for the chnl byte, which is not received in the hdr) */
skb_pull(skb, (NFCWILINK_HDR_LEN-1));
Expand Down

0 comments on commit d6650a2

Please sign in to comment.