Skip to content

Commit

Permalink
[SCSI] arcmsr: fix up sysfs values
Browse files Browse the repository at this point in the history
The sysfs files in arcmsr are non-standard in that they aren't simple
filename value pairs, the values actually contain preceeding text which
would have to be parsed.  The idea of sysfs files is that the file name
is the description and the contents is a simple value.

Fix up arcmsr to conform to this standard.

Acked-By: Erich Chen <erich@areca.com.tw>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
James Bottomley authored and James Bottomley committed Aug 2, 2006
1 parent 43d6b68 commit d67a70a
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions drivers/scsi/arcmsr/arcmsr_attr.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ arcmsr_free_sysfs_attr(struct AdapterControlBlock *acb) {
static ssize_t
arcmsr_attr_host_driver_version(struct class_device *cdev, char *buf) {
return snprintf(buf, PAGE_SIZE,
"ARCMSR: %s\n",
"%s\n",
ARCMSR_DRIVER_VERSION);
}

Expand All @@ -274,7 +274,7 @@ arcmsr_attr_host_driver_posted_cmd(struct class_device *cdev, char *buf) {
struct Scsi_Host *host = class_to_shost(cdev);
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;
return snprintf(buf, PAGE_SIZE,
"Current commands posted: %4d\n",
"%4d\n",
atomic_read(&acb->ccboutstandingcount));
}

Expand All @@ -283,7 +283,7 @@ arcmsr_attr_host_driver_reset(struct class_device *cdev, char *buf) {
struct Scsi_Host *host = class_to_shost(cdev);
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;
return snprintf(buf, PAGE_SIZE,
"SCSI Host Resets: %4d\n",
"%4d\n",
acb->num_resets);
}

Expand All @@ -292,7 +292,7 @@ arcmsr_attr_host_driver_abort(struct class_device *cdev, char *buf) {
struct Scsi_Host *host = class_to_shost(cdev);
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;
return snprintf(buf, PAGE_SIZE,
"SCSI Aborts/Timeouts: %4d\n",
"%4d\n",
acb->num_aborts);
}

Expand All @@ -301,7 +301,7 @@ arcmsr_attr_host_fw_model(struct class_device *cdev, char *buf) {
struct Scsi_Host *host = class_to_shost(cdev);
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;
return snprintf(buf, PAGE_SIZE,
"Adapter Model: %s\n",
"%s\n",
acb->firm_model);
}

Expand All @@ -311,7 +311,7 @@ arcmsr_attr_host_fw_version(struct class_device *cdev, char *buf) {
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;

return snprintf(buf, PAGE_SIZE,
"Firmware Version: %s\n",
"%s\n",
acb->firm_version);
}

Expand All @@ -321,7 +321,7 @@ arcmsr_attr_host_fw_request_len(struct class_device *cdev, char *buf) {
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;

return snprintf(buf, PAGE_SIZE,
"Reguest Lenth: %4d\n",
"%4d\n",
acb->firm_request_len);
}

Expand All @@ -331,7 +331,7 @@ arcmsr_attr_host_fw_numbers_queue(struct class_device *cdev, char *buf) {
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;

return snprintf(buf, PAGE_SIZE,
"Numbers of Queue: %4d\n",
"%4d\n",
acb->firm_numbers_queue);
}

Expand All @@ -341,7 +341,7 @@ arcmsr_attr_host_fw_sdram_size(struct class_device *cdev, char *buf) {
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;

return snprintf(buf, PAGE_SIZE,
"SDRAM Size: %4d\n",
"%4d\n",
acb->firm_sdram_size);
}

Expand All @@ -351,7 +351,7 @@ arcmsr_attr_host_fw_hd_channels(struct class_device *cdev, char *buf) {
struct AdapterControlBlock *acb = (struct AdapterControlBlock *) host->hostdata;

return snprintf(buf, PAGE_SIZE,
"Hard Disk Channels: %4d\n",
"%4d\n",
acb->firm_hd_channels);
}

Expand Down

0 comments on commit d67a70a

Please sign in to comment.