Skip to content

Commit

Permalink
PCI Hotplug: acpiphp: convert to acpi_get_pci_dev
Browse files Browse the repository at this point in the history
Now that acpi_get_pci_dev is available, let's use it instead of
acpi_get_pci_id.

Signed-off-by: Alex Chiang <achiang@hp.com>
Acked-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Alexander Chiang authored and Len Brown committed Jun 18, 2009
1 parent 97719a8 commit d6aa484
Showing 1 changed file with 7 additions and 18 deletions.
25 changes: 7 additions & 18 deletions drivers/pci/hotplug/acpiphp_glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -678,18 +678,9 @@ static void remove_bridge(acpi_handle handle)

static struct pci_dev * get_apic_pci_info(acpi_handle handle)
{
struct acpi_pci_id id;
struct pci_bus *bus;
struct pci_dev *dev;

if (ACPI_FAILURE(acpi_get_pci_id(handle, &id)))
return NULL;

bus = pci_find_bus(id.segment, id.bus);
if (!bus)
return NULL;

dev = pci_get_slot(bus, PCI_DEVFN(id.device, id.function));
dev = acpi_get_pci_dev(handle);
if (!dev)
return NULL;

Expand Down Expand Up @@ -1396,26 +1387,24 @@ static void acpiphp_sanitize_bus(struct pci_bus *bus)
/* Program resources in newly inserted bridge */
static int acpiphp_configure_bridge (acpi_handle handle)
{
struct acpi_pci_id pci_id;
struct pci_dev *dev;
struct pci_bus *bus;

if (ACPI_FAILURE(acpi_get_pci_id(handle, &pci_id))) {
dev = acpi_get_pci_dev(handle);
if (!dev) {
err("cannot get PCI domain and bus number for bridge\n");
return -EINVAL;
}
bus = pci_find_bus(pci_id.segment, pci_id.bus);
if (!bus) {
err("cannot find bus %d:%d\n",
pci_id.segment, pci_id.bus);
return -EINVAL;
}

bus = dev->bus;

pci_bus_size_bridges(bus);
pci_bus_assign_resources(bus);
acpiphp_sanitize_bus(bus);
acpiphp_set_hpp_values(handle, bus);
pci_enable_bridges(bus);
acpiphp_configure_ioapics(handle);
pci_dev_put(dev);
return 0;
}

Expand Down

0 comments on commit d6aa484

Please sign in to comment.