Skip to content

Commit

Permalink
tracing: convert irq trace points to new macros
Browse files Browse the repository at this point in the history
Impact: enhancement

Converted the two irq trace point macros. The entry macro copies
the name of the irq handler, thus it is better to simply use the
TRACE_FORMAT macro which uses the trace_printk.

The return of the handler does not need to record the name, thus
the faster C style handler is more approriate.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
  • Loading branch information
Steven Rostedt committed Mar 10, 2009
1 parent 12b5fdb commit d6e2ca4
Showing 1 changed file with 24 additions and 14 deletions.
38 changes: 24 additions & 14 deletions include/trace/irq_event_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,36 @@
#undef TRACE_SYSTEM
#define TRACE_SYSTEM irq

TRACE_EVENT_FORMAT(irq_handler_entry,
/*
* Tracepoint for entry of interrupt handler:
*/
TRACE_FORMAT(irq_handler_entry,
TP_PROTO(int irq, struct irqaction *action),
TP_ARGS(irq, action),
TP_FMT("irq=%d handler=%s", irq, action->name),
TRACE_STRUCT(
TRACE_FIELD(int, irq, irq)
),
TP_RAW_FMT("irq %d")
TP_FMT("irq=%d handler=%s", irq, action->name)
);

TRACE_EVENT_FORMAT(irq_handler_exit,
/*
* Tracepoint for return of an interrupt handler:
*/
TRACE_EVENT(irq_handler_exit,

TP_PROTO(int irq, struct irqaction *action, int ret),

TP_ARGS(irq, action, ret),
TP_FMT("irq=%d handler=%s return=%s",
irq, action->name, ret ? "handled" : "unhandled"),
TRACE_STRUCT(
TRACE_FIELD(int, irq, irq)
TRACE_FIELD(int, ret, ret)

TP_STRUCT__entry(
__field( int, irq )
__field( int, ret )
),
TP_RAW_FMT("irq %d ret %d")
);

TP_printk("irq=%d return=%s",
__entry->irq, __entry->ret ? "handled" : "unhandled"),

TP_fast_assign(
__entry->irq = irq;
__entry->ret = ret;
)
);

#undef TRACE_SYSTEM

0 comments on commit d6e2ca4

Please sign in to comment.