Skip to content

Commit

Permalink
Input: cyttsp - use PTR_ERR_OR_ZERO()
Browse files Browse the repository at this point in the history
The PTR_ERR_OR_ZERO() helper function checks if a pointer contains an
errno code and returns it or return 0 if that's not the case. Use the
helper instead of open coding the same logic in the driver. This was
found with make coccicheck that complains with the following warning:

drivers/input/touchscreen/cyttsp4_i2c.c:53:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Javier Martinez Canillas authored and Dmitry Torokhov committed Oct 2, 2015
1 parent c4517f8 commit d6f0c3d
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/input/touchscreen/cyttsp4_i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,7 @@ static int cyttsp4_i2c_probe(struct i2c_client *client,
ts = cyttsp4_probe(&cyttsp4_i2c_bus_ops, &client->dev, client->irq,
CYTTSP4_I2C_DATA_SIZE);

if (IS_ERR(ts))
return PTR_ERR(ts);

return 0;
return PTR_ERR_OR_ZERO(ts);
}

static int cyttsp4_i2c_remove(struct i2c_client *client)
Expand Down

0 comments on commit d6f0c3d

Please sign in to comment.