Skip to content

Commit

Permalink
dm thin: set pool read-only if breaking_sharing fails block allocation
Browse files Browse the repository at this point in the history
break_sharing() now handles an arbitrary alloc_data_block() error
the same way as provision_block(): marks pool read-only and errors the
cell.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
  • Loading branch information
Mike Snitzer committed Sep 6, 2013
1 parent 4fa5971 commit d6fc204
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/md/dm-thin.c
Original file line number Diff line number Diff line change
Expand Up @@ -1086,6 +1086,7 @@ static void break_sharing(struct thin_c *tc, struct bio *bio, dm_block_t block,
{
int r;
dm_block_t data_block;
struct pool *pool = tc->pool;

r = alloc_data_block(tc, &data_block);
switch (r) {
Expand All @@ -1095,13 +1096,14 @@ static void break_sharing(struct thin_c *tc, struct bio *bio, dm_block_t block,
break;

case -ENOSPC:
no_space(tc->pool, cell);
no_space(pool, cell);
break;

default:
DMERR_LIMIT("%s: alloc_data_block() failed: error = %d",
__func__, r);
cell_error(tc->pool, cell);
set_pool_mode(pool, PM_READ_ONLY);
cell_error(pool, cell);
break;
}
}
Expand Down

0 comments on commit d6fc204

Please sign in to comment.