Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 159680
b: refs/heads/master
c: 49d4b8b
h: refs/heads/master
v: v3
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Aug 14, 2009
1 parent 2258e45 commit d707948
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: f34c5c828439cedbc222030d7e45af69f947384d
refs/heads/master: 49d4b8ba97034469b941d00d5ca1e3b897394e35
14 changes: 1 addition & 13 deletions trunk/drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -1496,8 +1496,6 @@ static int sky2_up(struct net_device *dev)
sky2_set_vlan_mode(hw, port, sky2->vlgrp != NULL);
#endif

sky2->restarting = 0;

err = sky2_rx_start(sky2);
if (err)
goto err_out;
Expand All @@ -1508,9 +1506,6 @@ static int sky2_up(struct net_device *dev)
sky2_write32(hw, B0_IMSK, imask);
sky2_read32(hw, B0_IMSK);

/* wake queue incase we are restarting */
netif_wake_queue(dev);

if (netif_msg_ifup(sky2))
printk(KERN_INFO PFX "%s: enabling interface\n", dev->name);

Expand Down Expand Up @@ -1545,8 +1540,6 @@ static inline int tx_dist(unsigned tail, unsigned head)
/* Number of list elements available for next tx */
static inline int tx_avail(const struct sky2_port *sky2)
{
if (unlikely(sky2->restarting))
return 0;
return sky2->tx_pending - tx_dist(sky2->tx_cons, sky2->tx_prod);
}

Expand Down Expand Up @@ -1850,10 +1843,6 @@ static int sky2_down(struct net_device *dev)
if (netif_msg_ifdown(sky2))
printk(KERN_INFO PFX "%s: disabling interface\n", dev->name);

/* explicitly shut off tx incase we're restarting */
sky2->restarting = 1;
netif_tx_disable(dev);

/* Force flow control off */
sky2_write8(hw, SK_REG(port, GMAC_CTRL), GMC_PAUSE_OFF);

Expand Down Expand Up @@ -2382,7 +2371,7 @@ static inline void sky2_tx_done(struct net_device *dev, u16 last)
{
struct sky2_port *sky2 = netdev_priv(dev);

if (likely(netif_running(dev) && !sky2->restarting))
if (netif_running(dev))
sky2_tx_complete(sky2, last);
}

Expand Down Expand Up @@ -4327,7 +4316,6 @@ static __devinit struct net_device *sky2_init_netdev(struct sky2_hw *hw,
spin_lock_init(&sky2->phy_lock);
sky2->tx_pending = TX_DEF_PENDING;
sky2->rx_pending = RX_DEF_PENDING;
sky2->restarting = 0;

hw->dev[port] = dev;

Expand Down
1 change: 0 additions & 1 deletion trunk/drivers/net/sky2.h
Original file line number Diff line number Diff line change
Expand Up @@ -2053,7 +2053,6 @@ struct sky2_port {
#define SKY2_FLAG_AUTO_SPEED 0x0002
#define SKY2_FLAG_AUTO_PAUSE 0x0004

u8 restarting;
enum flow_control flow_mode;
enum flow_control flow_status;

Expand Down

0 comments on commit d707948

Please sign in to comment.