Skip to content

Commit

Permalink
slub: Check kasprintf results in kmem_cache_init()
Browse files Browse the repository at this point in the history
Small allocations may fail during slab bringup which is fatal. Add a BUG_ON()
so that we fail immediately rather than failing later during sysfs
processing.

Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
  • Loading branch information
Christoph Lameter authored and Pekka Enberg committed Jul 16, 2010
1 parent f90ec39 commit d7278bd
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions mm/slub.c
Original file line number Diff line number Diff line change
Expand Up @@ -3118,9 +3118,12 @@ void __init kmem_cache_init(void)
slab_state = UP;

/* Provide the correct kmalloc names now that the caches are up */
for (i = KMALLOC_SHIFT_LOW; i < SLUB_PAGE_SHIFT; i++)
kmalloc_caches[i]. name =
kasprintf(GFP_NOWAIT, "kmalloc-%d", 1 << i);
for (i = KMALLOC_SHIFT_LOW; i < SLUB_PAGE_SHIFT; i++) {
char *s = kasprintf(GFP_NOWAIT, "kmalloc-%d", 1 << i);

BUG_ON(!s);
kmalloc_caches[i].name = s;
}

#ifdef CONFIG_SMP
register_cpu_notifier(&slab_notifier);
Expand Down

0 comments on commit d7278bd

Please sign in to comment.