Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 109649
b: refs/heads/master
c: 4ab6a21
h: refs/heads/master
i:
  109647: 217ea37
v: v3
  • Loading branch information
Dominik Brodowski authored and Ingo Molnar committed Sep 6, 2008
1 parent f6bf3b3 commit d734063
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 18 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: dfdf748a61a21b7397b9f57c83de722de71dc56a
refs/heads/master: 4ab6a219113197425ac112e35e1ec8062c69888e
46 changes: 29 additions & 17 deletions trunk/drivers/clocksource/acpi_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include <linux/errno.h>
#include <linux/init.h>
#include <linux/pci.h>
#include <linux/delay.h>
#include <asm/io.h>

/*
Expand Down Expand Up @@ -175,10 +176,13 @@ static int verify_pmtmr_rate(void)
#define verify_pmtmr_rate() (0)
#endif

/* Number of monotonicity checks to perform during initialization */
#define ACPI_PM_MONOTONICITY_CHECKS 10

static int __init init_acpi_pm_clocksource(void)
{
cycle_t value1, value2;
unsigned int i;
unsigned int i, j, good = 0;

if (!pmtmr_ioport)
return -ENODEV;
Expand All @@ -187,24 +191,32 @@ static int __init init_acpi_pm_clocksource(void)
clocksource_acpi_pm.shift);

/* "verify" this timing source: */
value1 = clocksource_acpi_pm.read();
for (i = 0; i < 10000; i++) {
value2 = clocksource_acpi_pm.read();
if (value2 == value1)
continue;
if (value2 > value1)
goto pm_good;
if ((value2 < value1) && ((value2) < 0xFFF))
goto pm_good;
printk(KERN_INFO "PM-Timer had inconsistent results:"
" 0x%#llx, 0x%#llx - aborting.\n", value1, value2);
return -EINVAL;
for (j = 0; j < ACPI_PM_MONOTONICITY_CHECKS; j++) {
value1 = clocksource_acpi_pm.read();
for (i = 0; i < 10000; i++) {
value2 = clocksource_acpi_pm.read();
if (value2 == value1)
continue;
if (value2 > value1)
good++;
break;
if ((value2 < value1) && ((value2) < 0xFFF))
good++;
break;
printk(KERN_INFO "PM-Timer had inconsistent results:"
" 0x%#llx, 0x%#llx - aborting.\n",
value1, value2);
return -EINVAL;
}
udelay(300 * i);
}

if (good != ACPI_PM_MONOTONICITY_CHECKS) {
printk(KERN_INFO "PM-Timer failed consistency check "
" (0x%#llx) - aborting.\n", value1);
return -ENODEV;
}
printk(KERN_INFO "PM-Timer had no reasonable result:"
" 0x%#llx - aborting.\n", value1);
return -ENODEV;

pm_good:
if (verify_pmtmr_rate() != 0)
return -ENODEV;

Expand Down

0 comments on commit d734063

Please sign in to comment.