Skip to content

Commit

Permalink
usb: storagE: realtek_cr: fix sparse warnings
Browse files Browse the repository at this point in the history
Fix the following sparse warnings:

| drivers/usb/storage/realtek_cr.c:821:6: warning: symbol
|	'rts51x_invoke_transport' was not declared. Should
|	it be static?
|
| drivers/usb/storage/realtek_cr.c:980:5: warning: symbol
|	'realtek_cr_suspend' was not declared. Should it
|	be static?
|
| drivers/usb/storage/realtek_cr.c:518:23: warning: cast
|	truncates bits from constant value (fe47 becomes 47)

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Felipe Balbi authored and Greg Kroah-Hartman committed Nov 15, 2011
1 parent e2c83f0 commit d762ad4
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/usb/storage/realtek_cr.c
Original file line number Diff line number Diff line change
Expand Up @@ -507,15 +507,14 @@ static int enable_oscillator(struct us_data *us)
static int __do_config_autodelink(struct us_data *us, u8 *data, u16 len)
{
int retval;
u16 addr = 0xFE47;
u8 cmnd[12] = {0};

US_DEBUGP("%s, addr = 0x%x, len = %d\n", __FUNCTION__, addr, len);
US_DEBUGP("%s, addr = 0xfe47, len = %d\n", __FUNCTION__, len);

cmnd[0] = 0xF0;
cmnd[1] = 0x0E;
cmnd[2] = (u8)(addr >> 8);
cmnd[3] = (u8)addr;
cmnd[2] = 0xfe;
cmnd[3] = 0x47;
cmnd[4] = (u8)(len >> 8);
cmnd[5] = (u8)len;

Expand Down Expand Up @@ -818,7 +817,7 @@ static inline int working_scsi(struct scsi_cmnd *srb)
return 1;
}

void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)
static void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)
{
struct rts51x_chip *chip = (struct rts51x_chip *)(us->extra);
static int card_first_show = 1;
Expand Down Expand Up @@ -977,7 +976,7 @@ static void realtek_cr_destructor(void *extra)
}

#ifdef CONFIG_PM
int realtek_cr_suspend(struct usb_interface *iface, pm_message_t message)
static int realtek_cr_suspend(struct usb_interface *iface, pm_message_t message)
{
struct us_data *us = usb_get_intfdata(iface);

Expand Down

0 comments on commit d762ad4

Please sign in to comment.