Skip to content

Commit

Permalink
[PATCH] fuse: introduce list for requests under I/O
Browse files Browse the repository at this point in the history
Create a new list for requests in the process of being transfered to/from
userspace.  This will be needed to be able to abort all requests even those
currently under I/O

Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Miklos Szeredi authored and Linus Torvalds committed Jan 17, 2006
1 parent 83cfd49 commit d77a1d5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
8 changes: 4 additions & 4 deletions fs/fuse/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ static void process_init_reply(struct fuse_conn *fc, struct fuse_req *req)
*/
static void request_end(struct fuse_conn *fc, struct fuse_req *req)
{
list_del(&req->list);
req->state = FUSE_REQ_FINISHED;
spin_unlock(&fuse_lock);
if (req->background) {
Expand Down Expand Up @@ -641,7 +642,7 @@ static ssize_t fuse_dev_readv(struct file *file, const struct iovec *iov,

req = list_entry(fc->pending.next, struct fuse_req, list);
req->state = FUSE_REQ_READING;
list_del_init(&req->list);
list_move(&req->list, &fc->io);

in = &req->in;
reqsize = in->h.len;
Expand Down Expand Up @@ -675,7 +676,7 @@ static ssize_t fuse_dev_readv(struct file *file, const struct iovec *iov,
request_end(fc, req);
else {
req->state = FUSE_REQ_SENT;
list_add_tail(&req->list, &fc->processing);
list_move_tail(&req->list, &fc->processing);
spin_unlock(&fuse_lock);
}
return reqsize;
Expand Down Expand Up @@ -768,14 +769,14 @@ static ssize_t fuse_dev_writev(struct file *file, const struct iovec *iov,
if (!req)
goto err_unlock;

list_del_init(&req->list);
if (req->interrupted) {
spin_unlock(&fuse_lock);
fuse_copy_finish(&cs);
spin_lock(&fuse_lock);
request_end(fc, req);
return -ENOENT;
}
list_move(&req->list, &fc->io);
req->out.h = oh;
req->locked = 1;
cs.req = req;
Expand Down Expand Up @@ -835,7 +836,6 @@ static void end_requests(struct fuse_conn *fc, struct list_head *head)
while (!list_empty(head)) {
struct fuse_req *req;
req = list_entry(head->next, struct fuse_req, list);
list_del_init(&req->list);
req->out.h.error = -ECONNABORTED;
request_end(fc, req);
spin_lock(&fuse_lock);
Expand Down
7 changes: 5 additions & 2 deletions fs/fuse/fuse_i.h
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ enum fuse_req_state {
* A request to the client
*/
struct fuse_req {
/** This can be on either unused_list, pending or processing
lists in fuse_conn */
/** This can be on either unused_list, pending processing or
io lists in fuse_conn */
struct list_head list;

/** Entry on the background list */
Expand Down Expand Up @@ -223,6 +223,9 @@ struct fuse_conn {
/** The list of requests being processed */
struct list_head processing;

/** The list of requests under I/O */
struct list_head io;

/** Requests put in the background (RELEASE or any other
interrupted request) */
struct list_head background;
Expand Down
1 change: 1 addition & 0 deletions fs/fuse/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ static struct fuse_conn *new_conn(void)
init_waitqueue_head(&fc->waitq);
INIT_LIST_HEAD(&fc->pending);
INIT_LIST_HEAD(&fc->processing);
INIT_LIST_HEAD(&fc->io);
INIT_LIST_HEAD(&fc->unused_list);
INIT_LIST_HEAD(&fc->background);
sema_init(&fc->outstanding_sem, 1); /* One for INIT */
Expand Down

0 comments on commit d77a1d5

Please sign in to comment.