Skip to content

Commit

Permalink
[CPUFREQ] speedstep-centrino should ignore upper performance control …
Browse files Browse the repository at this point in the history
…bits

On some systems such as the IBM x3650 there are bits set in the
upper half of the control values provided by the _PSS object.
These bits are only relevant for cpufreq drivers that use IO ports
which are not currently supported by the speedstep-centrino driver.
The current MSR oriented code assumes that upper bits are not set
and thus fails to work correctly when they are.  e.g. the control
and status value equality check fails even though the ACPI spec
allows the inequality.

Signed-off-by: Gary Hade <garyh@us.ibm.com>
Signed-off-by: Dave Jones <davej@redhat.com>
  • Loading branch information
Gary Hade authored and Dave Jones committed Nov 8, 2006
1 parent 4e74663 commit d7a1944
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,10 @@ static int centrino_cpu_init_acpi(struct cpufreq_policy *policy)
}

for (i=0; i<p->state_count; i++) {
/* clear high bits (set by some BIOSes) that are non-relevant and
problematic for this driver's MSR only frequency transition code */
p->states[i].control &= 0xffff;

if (p->states[i].control != p->states[i].status) {
dprintk("Different control (%llu) and status values (%llu)\n",
p->states[i].control, p->states[i].status);
Expand Down

0 comments on commit d7a1944

Please sign in to comment.