Skip to content

Commit

Permalink
sched: fix debugging
Browse files Browse the repository at this point in the history
Revert debugging commit 7ba2e74.
print_cfs_rq_tasks() can induce live-lock if a task is dequeued
during list traversal.

Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Mike Galbraith authored and Ingo Molnar committed May 5, 2008
1 parent 673a90a commit d7dcdc1
Showing 1 changed file with 0 additions and 27 deletions.
27 changes: 0 additions & 27 deletions kernel/sched_fair.c
Original file line number Diff line number Diff line change
Expand Up @@ -1613,40 +1613,13 @@ static const struct sched_class fair_sched_class = {
};

#ifdef CONFIG_SCHED_DEBUG
static void
print_cfs_rq_tasks(struct seq_file *m, struct cfs_rq *cfs_rq, int depth)
{
struct sched_entity *se;

if (!cfs_rq)
return;

list_for_each_entry_rcu(se, &cfs_rq->tasks, group_node) {
int i;

for (i = depth; i; i--)
seq_puts(m, " ");

seq_printf(m, "%lu %s %lu\n",
se->load.weight,
entity_is_task(se) ? "T" : "G",
calc_delta_weight(SCHED_LOAD_SCALE, se)
);
if (!entity_is_task(se))
print_cfs_rq_tasks(m, group_cfs_rq(se), depth + 1);
}
}

static void print_cfs_stats(struct seq_file *m, int cpu)
{
struct cfs_rq *cfs_rq;

rcu_read_lock();
for_each_leaf_cfs_rq(cpu_rq(cpu), cfs_rq)
print_cfs_rq(m, cpu, cfs_rq);

seq_printf(m, "\nWeight tree:\n");
print_cfs_rq_tasks(m, &cpu_rq(cpu)->cfs, 1);
rcu_read_unlock();
}
#endif

0 comments on commit d7dcdc1

Please sign in to comment.