Skip to content

Commit

Permalink
[ARM] i.MX serial: fix IRQ allocation
Browse files Browse the repository at this point in the history
If RTS interrupt is caused by RTS senzing logic inside i.MX UART module the
IRQ type cannot be set.

It applies only for interrupts going through GPIO layer.  The problem has
been noticed by Konstantin Kletschke some time ago.

  No IRQF_TRIGGER set_type function for IRQ 26 (MPU)

I would not change type to fixed 0, because it could be possible to use
different GPIO MX1 pin for RTS in the theory.  On the other hand it is only
for documentation purposes now, because RTS read code would have to be
adjusted in such case.

Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Pavel Pisa authored and Russell King committed Feb 11, 2007
1 parent 8c0b254 commit d7ea10d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/serial/imx.c
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,8 @@ static int imx_startup(struct uart_port *port)
if (retval) goto error_out2;

retval = request_irq(sport->rtsirq, imx_rtsint,
IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
(sport->rtsirq < IMX_IRQS) ? 0 :
IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
DRIVER_NAME, sport);
if (retval) goto error_out3;

Expand Down

0 comments on commit d7ea10d

Please sign in to comment.