Skip to content

Commit

Permalink
[SCSI] sym53c8xx: Fix bogus sym_que_entry re-implementation of contai…
Browse files Browse the repository at this point in the history
…ner_of

The sym53c8xx driver, for some reason, seems to mostly re-implement
linux/list.h with added bogosity. The main one is it's implementation
of sym_que_entry which spits warnings with recent gcc's on some
64 bits architectures.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Benjamin Herrenschmidt authored and James Bottomley committed Jul 12, 2008
1 parent 02a1e3c commit d7f305e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/scsi/sym53c8xx_2/sym_misc.h
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ static __inline void sym_que_move(struct sym_quehead *orig,
}
}

#define sym_que_entry(ptr, type, member) \
((type *)((char *)(ptr)-(unsigned int)(&((type *)0)->member)))

#define sym_que_entry(ptr, type, member) container_of(ptr, type, member)

#define sym_insque(new, pos) __sym_que_add(new, pos, (pos)->flink)

Expand Down

0 comments on commit d7f305e

Please sign in to comment.