Skip to content

Commit

Permalink
Staging: hv: hv_mouse: use an anonymous union for struct mousevsc_prt…
Browse files Browse the repository at this point in the history
…_msg

Much nicer than having an ugly 'u.' in the structure usage, welcome to
the 2000's...

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Mar 3, 2011
1 parent e93eff9 commit d7fa1a4
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/staging/hv/hv_mouse.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ struct mousevsc_prt_msg {
struct synthhid_protocol_request Request;
struct synthhid_protocol_response Response;
struct synthhid_device_info_ack Ack;
} u;
};
};

/*
Expand Down Expand Up @@ -385,9 +385,9 @@ static void MousevscOnReceiveDeviceInfo(struct mousevsc_dev *InputDevice, struct
ack.PacketType = PipeMessageData;
ack.DataSize = sizeof(struct synthhid_device_info_ack);

ack.u.Ack.header.type = SynthHidInitialDeviceInfoAck;
ack.u.Ack.header.size = 1;
ack.u.Ack.reserved = 0;
ack.Ack.header.type = SynthHidInitialDeviceInfoAck;
ack.Ack.header.size = 1;
ack.Ack.reserved = 0;

ret = vmbus_sendpacket(InputDevice->Device->channel,
&ack,
Expand Down Expand Up @@ -608,9 +608,9 @@ static int MousevscConnectToVsp(struct hv_device *Device)
request->PacketType = PipeMessageData;
request->DataSize = sizeof(struct synthhid_protocol_request);

request->u.Request.header.type = SynthHidProtocolRequest;
request->u.Request.header.size = sizeof(unsigned long);
request->u.Request.version_requested.version = SYNTHHID_INPUT_VERSION;
request->Request.header.type = SynthHidProtocolRequest;
request->Request.header.size = sizeof(unsigned long);
request->Request.version_requested.version = SYNTHHID_INPUT_VERSION;

pr_info("synthhid protocol request...");

Expand All @@ -635,7 +635,7 @@ static int MousevscConnectToVsp(struct hv_device *Device)

response = &inputDevice->ProtocolResp;

if (!response->u.Response.approved) {
if (!response->Response.approved) {
pr_err("synthhid protocol request failed (version %d)",
SYNTHHID_INPUT_VERSION);
ret = -1;
Expand Down

0 comments on commit d7fa1a4

Please sign in to comment.