Skip to content

Commit

Permalink
nfsd4: put_nfs4_client does not require state lock
Browse files Browse the repository at this point in the history
Since free_client() is guaranteed to only be called once, and to only
touch the client structure itself (not any common data structures), it
has no need for the state lock.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Cc: Alexandros Batsakis <batsakis@netapp.com>
  • Loading branch information
J. Bruce Fields committed Mar 18, 2009
1 parent 18f8273 commit d7fdcfe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfsd/nfs4callback.c
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,8 @@ nfsd4_cb_recall(struct nfs4_delegation *dp)
* Success or failure, now we're either waiting for lease expiration
* or deleg_return.
*/
nfs4_lock_state();
put_nfs4_client(clp);
nfs4_lock_state();
nfs4_put_delegation(dp);
nfs4_unlock_state();
return;
Expand Down

0 comments on commit d7fdcfe

Please sign in to comment.