Skip to content

Commit

Permalink
[SCSI] iscsi bugfixes: send correct error values to userspace
Browse files Browse the repository at this point in the history
In the xmit patch we are sending a -EXXX value to iscsi_conn_failure
which is causing userspace to get confused.

We should be sending a ISCSI_ERR_* value that userspace understands.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Mike Christie authored and James Bottomley committed Jul 28, 2006
1 parent 8d4fbd3 commit d82967c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/scsi/iscsi_tcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ iscsi_tcp_data_recv(read_descriptor_t *rd_desc, struct sk_buff *skb,
if (rc == -EAGAIN)
goto nomore;
else {
iscsi_conn_failure(conn, rc);
iscsi_conn_failure(conn, ISCSI_ERR_CONN_FAILED);
return 0;
}
}
Expand All @@ -859,7 +859,7 @@ iscsi_tcp_data_recv(read_descriptor_t *rd_desc, struct sk_buff *skb,
}
tcp_conn->in_progress = IN_PROGRESS_DATA_RECV;
} else if (rc) {
iscsi_conn_failure(conn, rc);
iscsi_conn_failure(conn, ISCSI_ERR_CONN_FAILED);
return 0;
}
}
Expand Down Expand Up @@ -897,7 +897,7 @@ iscsi_tcp_data_recv(read_descriptor_t *rd_desc, struct sk_buff *skb,
if (rc) {
if (rc == -EAGAIN)
goto again;
iscsi_conn_failure(conn, rc);
iscsi_conn_failure(conn, ISCSI_ERR_CONN_FAILED);
return 0;
}
tcp_conn->in.copy -= tcp_conn->in.padding;
Expand Down

0 comments on commit d82967c

Please sign in to comment.