Skip to content

Commit

Permalink
[PATCH] MACB: Use struct delayed_work instead of struct work_struct
Browse files Browse the repository at this point in the history
The macb driver calls schedule_delayed_work() and friends, so we need
to use a struct delayed_work along with it. The conversion was
explained by David Howells on lkml Dec 5 2006:

http://lkml.org/lkml/2006/12/5/269

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Haavard Skinnemoen authored and Jeff Garzik committed Dec 11, 2006
1 parent 68dc44a commit d836cae
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions drivers/net/macb.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,9 @@ static void macb_update_stats(struct macb *bp)
*p += readl(reg);
}

static void macb_periodic_task(void *arg)
static void macb_periodic_task(struct work_struct *work)
{
struct macb *bp = arg;
struct macb *bp = container_of(work, struct macb, periodic_task.work);

macb_update_stats(bp);
macb_check_media(bp, 1, 0);
Expand Down Expand Up @@ -1088,7 +1088,7 @@ static int __devinit macb_probe(struct platform_device *pdev)

dev->base_addr = regs->start;

INIT_WORK(&bp->periodic_task, macb_periodic_task, bp);
INIT_DELAYED_WORK(&bp->periodic_task, macb_periodic_task);
mutex_init(&bp->mdio_mutex);
init_completion(&bp->mdio_complete);

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/macb.h
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ struct macb {

unsigned int rx_pending, tx_pending;

struct work_struct periodic_task;
struct delayed_work periodic_task;

struct mutex mdio_mutex;
struct completion mdio_complete;
Expand Down

0 comments on commit d836cae

Please sign in to comment.