Skip to content

Commit

Permalink
ath5k: Move debugfs under ieee80211/[wiphy-name]
Browse files Browse the repository at this point in the history
This automatically keeps things proper when wiphy
is renamed.

Based on patch by Johannes Berg <johannes@sipsolutions.net>

Signed-off-by: Ben Greear <greearb@candelatech.com>
Acked-by: Bruno Randolf <br1@einfach.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Ben Greear authored and John W. Linville committed Oct 13, 2010
1 parent 10d8dad commit d84a35d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 36 deletions.
7 changes: 1 addition & 6 deletions drivers/net/wireless/ath/ath5k/base.c
Original file line number Diff line number Diff line change
Expand Up @@ -3541,8 +3541,6 @@ ath5k_pci_probe(struct pci_dev *pdev,
sc->hw = hw;
sc->pdev = pdev;

ath5k_debug_init_device(sc);

/*
* Mark the device as detached to avoid processing
* interrupts until setup is complete.
Expand Down Expand Up @@ -3650,6 +3648,7 @@ ath5k_pci_probe(struct pci_dev *pdev,
}
}

ath5k_debug_init_device(sc);

/* ready to process interrupts */
__clear_bit(ATH_STAT_INVALID, sc->status);
Expand Down Expand Up @@ -3736,8 +3735,6 @@ init_ath5k_pci(void)
{
int ret;

ath5k_debug_init();

ret = pci_register_driver(&ath5k_pci_driver);
if (ret) {
printk(KERN_ERR "ath5k_pci: can't register pci driver\n");
Expand All @@ -3751,8 +3748,6 @@ static void __exit
exit_ath5k_pci(void)
{
pci_unregister_driver(&ath5k_pci_driver);

ath5k_debug_finish();
}

module_init(init_ath5k_pci);
Expand Down
20 changes: 2 additions & 18 deletions drivers/net/wireless/ath/ath5k/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@ module_param_named(debug, ath5k_debug, uint, 0);
#include "reg.h"
#include "ani.h"

static struct dentry *ath5k_global_debugfs;

static int ath5k_debugfs_open(struct inode *inode, struct file *file)
{
file->private_data = inode->i_private;
Expand Down Expand Up @@ -882,21 +880,13 @@ static const struct file_operations fops_queue = {
};


/* init */

void
ath5k_debug_init(void)
{
ath5k_global_debugfs = debugfs_create_dir("ath5k", NULL);
}

void
ath5k_debug_init_device(struct ath5k_softc *sc)
{
sc->debug.level = ath5k_debug;

sc->debug.debugfs_phydir = debugfs_create_dir(wiphy_name(sc->hw->wiphy),
ath5k_global_debugfs);
sc->debug.debugfs_phydir = debugfs_create_dir("ath5k",
sc->hw->wiphy->debugfsdir);

sc->debug.debugfs_debug = debugfs_create_file("debug",
S_IWUSR | S_IRUSR,
Expand Down Expand Up @@ -936,12 +926,6 @@ ath5k_debug_init_device(struct ath5k_softc *sc)
&fops_queue);
}

void
ath5k_debug_finish(void)
{
debugfs_remove(ath5k_global_debugfs);
}

void
ath5k_debug_finish_device(struct ath5k_softc *sc)
{
Expand Down
12 changes: 0 additions & 12 deletions drivers/net/wireless/ath/ath5k/debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,9 @@ enum ath5k_debug_level {
__func__, __LINE__, ##__VA_ARGS__); \
} while (0)

void
ath5k_debug_init(void);

void
ath5k_debug_init_device(struct ath5k_softc *sc);

void
ath5k_debug_finish(void);

void
ath5k_debug_finish_device(struct ath5k_softc *sc);

Expand Down Expand Up @@ -173,15 +167,9 @@ static inline void __attribute__ ((format (printf, 3, 4)))
ATH5K_DBG_UNLIMIT(struct ath5k_softc *sc, unsigned int m, const char *fmt, ...)
{}

static inline void
ath5k_debug_init(void) {}

static inline void
ath5k_debug_init_device(struct ath5k_softc *sc) {}

static inline void
ath5k_debug_finish(void) {}

static inline void
ath5k_debug_finish_device(struct ath5k_softc *sc) {}

Expand Down

0 comments on commit d84a35d

Please sign in to comment.