Skip to content

Commit

Permalink
drm/i915: don't set the FBC plane select bits on HSW+
Browse files Browse the repository at this point in the history
This commit is just to make the intentions explicit: on HSW+ these
bits are MBZ, but since we only support plane A and the macro
evaluates to zero when plane A is the parameter, we're not fixing any
bug.

v2:
 - Remove useless extra blank like (Chris).
 - Init dpfc_ctl in another place (Chris).

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Paulo Zanoni authored and Daniel Vetter committed Jun 15, 2015
1 parent 2e8144a commit d8514d6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/gpu/drm/i915/intel_fbc.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,10 @@ static void gen7_fbc_enable(struct drm_crtc *crtc)

dev_priv->fbc.enabled = true;

dpfc_ctl = IVB_DPFC_CTL_PLANE(intel_crtc->plane);
dpfc_ctl = 0;
if (IS_IVYBRIDGE(dev))
dpfc_ctl |= IVB_DPFC_CTL_PLANE(intel_crtc->plane);

if (drm_format_plane_cpp(fb->pixel_format, 0) == 2)
dev_priv->fbc.threshold++;

Expand Down

0 comments on commit d8514d6

Please sign in to comment.