Skip to content

Commit

Permalink
[media] lirc_dev: get irctl from irctls by inode again
Browse files Browse the repository at this point in the history
Can't explain it (yet), but I've seen the 'get irctl via private_data'
setup fail for a number of people (ioctl called before its filled in?),
so lets go back to a variant of the old way, but one that still works
with unlocked_ioctl.

Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Jarod Wilson authored and Mauro Carvalho Chehab committed Oct 22, 2010
1 parent 90dc4cf commit d889a13
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/media/IR/lirc_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,6 @@ int lirc_dev_fop_open(struct inode *inode, struct file *file)
retval = -ENODEV;
goto error;
}
file->private_data = ir;

dev_dbg(ir->d.dev, LOGHEAD "open called\n", ir->d.name, ir->d.minor);

Expand Down Expand Up @@ -528,7 +527,7 @@ long lirc_dev_fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
{
__u32 mode;
int result = 0;
struct irctl *ir = file->private_data;
struct irctl *ir = irctls[iminor(file->f_dentry->d_inode)];

if (!ir) {
printk(KERN_ERR "lirc_dev: %s: no irctl found!\n", __func__);
Expand Down

0 comments on commit d889a13

Please sign in to comment.