Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 126820
b: refs/heads/master
c: 731a55b
h: refs/heads/master
v: v3
  • Loading branch information
Thomas Gleixner authored and Ingo Molnar committed Jan 5, 2009
1 parent c92f36f commit d93e984
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 16 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d5fd43c4ae04523e1dcd7794f9c511b289851350
refs/heads/master: 731a55ba0f17064f85903b7bf8e24849ec6cfa20
25 changes: 10 additions & 15 deletions trunk/kernel/hrtimer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1504,11 +1504,6 @@ static void __cpuinit init_hrtimers_cpu(int cpu)

#ifdef CONFIG_HOTPLUG_CPU

static void tickle_timers(void *arg)
{
hrtimer_peek_ahead_timers();
}

static void migrate_hrtimer_list(struct hrtimer_clock_base *old_base,
struct hrtimer_clock_base *new_base)
{
Expand Down Expand Up @@ -1547,20 +1542,19 @@ static void migrate_hrtimer_list(struct hrtimer_clock_base *old_base,
static void migrate_hrtimers(int scpu)
{
struct hrtimer_cpu_base *old_base, *new_base;
int dcpu, i;
int i;

BUG_ON(cpu_online(scpu));
old_base = &per_cpu(hrtimer_bases, scpu);
new_base = &get_cpu_var(hrtimer_bases);

dcpu = smp_processor_id();

tick_cancel_sched_timer(scpu);

local_irq_disable();
old_base = &per_cpu(hrtimer_bases, scpu);
new_base = &__get_cpu_var(hrtimer_bases);
/*
* The caller is globally serialized and nobody else
* takes two locks at once, deadlock is not possible.
*/
spin_lock_irq(&new_base->lock);
spin_lock(&new_base->lock);
spin_lock_nested(&old_base->lock, SINGLE_DEPTH_NESTING);

for (i = 0; i < HRTIMER_MAX_CLOCK_BASES; i++) {
Expand All @@ -1569,10 +1563,11 @@ static void migrate_hrtimers(int scpu)
}

spin_unlock(&old_base->lock);
spin_unlock_irq(&new_base->lock);
put_cpu_var(hrtimer_bases);
spin_unlock(&new_base->lock);

smp_call_function_single(dcpu, tickle_timers, NULL, 0);
/* Check, if we got expired work to do */
__hrtimer_peek_ahead_timers();
local_irq_enable();
}

#endif /* CONFIG_HOTPLUG_CPU */
Expand Down

0 comments on commit d93e984

Please sign in to comment.