---

yaml
---
r: 330617
b: refs/heads/master
c: 77e28ec
h: refs/heads/master
i:
  330615: 7633738
v: v3

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: d32be21800feb38d51a584437f1a5eb3f4126a17
+refs/heads/master: 77e28ec27927dbb130d84a9fe7cbe85bf6bf47ea

trunk/drivers/media/dvb/dvb-usb/ec168.c

@@ -209,31 +209,28 @@ static int ec168_identify_state(struct dvb_usb_device *d)
 static int ec168_download_firmware(struct dvb_usb_device *d,
 		const struct firmware *fw)
 {
-	int i, len, packets, remainder, ret;
-	u16 addr = 0x0000; /* firmware start address */
+	int ret, len, remaining;
 	struct ec168_req req = {DOWNLOAD_FIRMWARE, 0, 0, 0, NULL};
 	pr_debug("%s:\n", __func__);
 
-	#define FW_PACKET_MAX_DATA  2048
-	packets = fw->size / FW_PACKET_MAX_DATA;
-	remainder = fw->size % FW_PACKET_MAX_DATA;
-	len = FW_PACKET_MAX_DATA;
-	for (i = 0; i <= packets; i++) {
-		if (i == packets)  /* set size of the last packet */
-			len = remainder;
+	#define LEN_MAX 2048 /* max packet size */
+	for (remaining = fw->size; remaining > 0; remaining -= LEN_MAX) {
+		len = remaining;
+		if (len > LEN_MAX)
+			len = LEN_MAX;
 
 		req.size = len;
-		req.data = (u8 *)(fw->data + i * FW_PACKET_MAX_DATA);
-		req.index = addr;
-		addr += FW_PACKET_MAX_DATA;
+		req.data = (u8 *) &fw->data[fw->size - remaining];
+		req.index = fw->size - remaining;
 
 		ret = ec168_ctrl_msg(d, &req);
 		if (ret) {
-			pr_err("%s: firmware download failed=%d packet=%d\n",
-					KBUILD_MODNAME, ret, i);
+			pr_err("%s: firmware download failed=%d\n",
+					KBUILD_MODNAME, ret);
 			goto error;
 		}
 	}
+
 	req.size = 0;
 
 	/* set "warm"? */