Skip to content

Commit

Permalink
dm thin metadata: remove pointless label from __commit_transaction
Browse files Browse the repository at this point in the history
Remove the pointless label 'out' from __commit_transaction in
dm-thin-metadata.c

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
  • Loading branch information
Joe Thornber authored and Alasdair G Kergon committed Jul 27, 2012
1 parent 3caf6d7 commit d973ac1
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions drivers/md/dm-thin-metadata.c
Original file line number Diff line number Diff line change
Expand Up @@ -597,31 +597,31 @@ static int __commit_transaction(struct dm_pool_metadata *pmd)

r = __write_changed_details(pmd);
if (r < 0)
goto out;
return r;

if (!pmd->need_commit)
goto out;
return r;

r = dm_sm_commit(pmd->data_sm);
if (r < 0)
goto out;
return r;

r = dm_tm_pre_commit(pmd->tm);
if (r < 0)
goto out;
return r;

r = dm_sm_root_size(pmd->metadata_sm, &metadata_len);
if (r < 0)
goto out;
return r;

r = dm_sm_root_size(pmd->data_sm, &data_len);
if (r < 0)
goto out;
return r;

r = dm_bm_write_lock(pmd->bm, THIN_SUPERBLOCK_LOCATION,
&sb_validator, &sblock);
if (r)
goto out;
return r;

disk_super = dm_block_data(sblock);
disk_super->time = cpu_to_le32(pmd->time);
Expand All @@ -644,7 +644,6 @@ static int __commit_transaction(struct dm_pool_metadata *pmd)
if (!r)
pmd->need_commit = 0;

out:
return r;

out_locked:
Expand Down

0 comments on commit d973ac1

Please sign in to comment.