Skip to content

Commit

Permalink
x86_64: Don't use softirq safe locks in smp_call_function
Browse files Browse the repository at this point in the history
It is not fully softirq safe anyways.

Can't do a WARN_ON unfortunately because it could trigger in the
panic case.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Jul 22, 2007
1 parent af3e9a2 commit d9c6d69
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/x86_64/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,9 @@ int smp_call_function_single (int cpu, void (*func) (void *info), void *info,
return 0;
}

spin_lock_bh(&call_lock);
spin_lock(&call_lock);
__smp_call_function_single(cpu, func, info, nonatomic, wait);
spin_unlock_bh(&call_lock);
spin_unlock(&call_lock);
put_cpu();
return 0;
}
Expand Down

0 comments on commit d9c6d69

Please sign in to comment.