Skip to content

Commit

Permalink
x86: Use bitmap library functions
Browse files Browse the repository at this point in the history
Use bitmap_set()/bitmap_clear() to fill/zero a region of a
bitmap instead of doing set_bit()/clear_bit() each bit.

This change has been tested with ioperm() and there's no
change in behavior.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
LKML-Reference: <1297867715-20394-1-git-send-email-akinobu.mita@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Akinobu Mita authored and Ingo Molnar committed Feb 17, 2011
1 parent b82fef8 commit da1016d
Showing 1 changed file with 5 additions and 15 deletions.
20 changes: 5 additions & 15 deletions arch/x86/kernel/ioport.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,9 @@
#include <linux/slab.h>
#include <linux/thread_info.h>
#include <linux/syscalls.h>
#include <linux/bitmap.h>
#include <asm/syscalls.h>

/* Set EXTENT bits starting at BASE in BITMAP to value TURN_ON. */
static void set_bitmap(unsigned long *bitmap, unsigned int base,
unsigned int extent, int new_value)
{
unsigned int i;

for (i = base; i < base + extent; i++) {
if (new_value)
__set_bit(i, bitmap);
else
__clear_bit(i, bitmap);
}
}

/*
* this changes the io permissions bitmap in the current task.
*/
Expand Down Expand Up @@ -69,7 +56,10 @@ asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int turn_on)
*/
tss = &per_cpu(init_tss, get_cpu());

set_bitmap(t->io_bitmap_ptr, from, num, !turn_on);
if (turn_on)
bitmap_clear(t->io_bitmap_ptr, from, num);
else
bitmap_set(t->io_bitmap_ptr, from, num);

/*
* Search for a (possibly new) maximum. This is simple and stupid,
Expand Down

0 comments on commit da1016d

Please sign in to comment.