Skip to content

Commit

Permalink
[ARM] pxafb: fix building issue of incorrect reference
Browse files Browse the repository at this point in the history
Commit "d2a34c1 drivers/video: Move dereference after NULL test" introduced
a build error of "fbi->dev->platform_data->smart_update" being unknown type
to the compiler, fix this by removing the unnecessary test of 'fbi'.

Cc: Julia Lawall <julia@diku.dk>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
  • Loading branch information
Eric Miao committed Dec 29, 2009
1 parent 6b7b284 commit da2c3f0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/video/pxafb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1221,9 +1221,9 @@ static void setup_smart_timing(struct pxafb_info *fbi,
static int pxafb_smart_thread(void *arg)
{
struct pxafb_info *fbi = arg;
struct pxafb_mach_info *inf;
struct pxafb_mach_info *inf = fbi->dev->platform_data;

if (!fbi || !fbi->dev->platform_data->smart_update) {
if (!inf->smart_update) {
pr_err("%s: not properly initialized, thread terminated\n",
__func__);
return -EINVAL;
Expand Down

0 comments on commit da2c3f0

Please sign in to comment.