Skip to content

Commit

Permalink
i2c: Bus drivers don't have to support I2C_M_REV_DIR_ADDR
Browse files Browse the repository at this point in the history
I2C bus drivers don't have to support I2C_M_REV_DIR_ADDR. It is a
deviation from the I2C specification, which only makes sense to
implement when really needed.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Ben Dooks <ben-linux@fluff.org>
  • Loading branch information
Jean Delvare committed Dec 6, 2009
1 parent 194684e commit da44bde
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 11 deletions.
6 changes: 0 additions & 6 deletions drivers/i2c/busses/i2c-iop3xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@ iic_cook_addr(struct i2c_msg *msg)
if (msg->flags & I2C_M_RD)
addr |= 1;

/*
* Read or Write?
*/
if (msg->flags & I2C_M_REV_DIR_ADDR)
addr ^= 1;

return addr;
}

Expand Down
3 changes: 0 additions & 3 deletions drivers/i2c/busses/i2c-mv64xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,6 @@ mv64xxx_i2c_prepare_for_io(struct mv64xxx_i2c_data *drv_data,
if (msg->flags & I2C_M_RD)
dir = 1;

if (msg->flags & I2C_M_REV_DIR_ADDR)
dir ^= 1;

if (msg->flags & I2C_M_TEN) {
drv_data->addr1 = 0xf0 | (((u32)msg->addr & 0x300) >> 7) | dir;
drv_data->addr2 = (u32)msg->addr & 0xff;
Expand Down
2 changes: 0 additions & 2 deletions drivers/i2c/busses/i2c-powermac.c
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,6 @@ static int i2c_powermac_master_xfer( struct i2c_adapter *adap,
return -EINVAL;
read = (msgs->flags & I2C_M_RD) != 0;
addrdir = (msgs->addr << 1) | read;
if (msgs->flags & I2C_M_REV_DIR_ADDR)
addrdir ^= 1;

rc = pmac_i2c_open(bus, 0);
if (rc) {
Expand Down

0 comments on commit da44bde

Please sign in to comment.