Skip to content

Commit

Permalink
cciss: fix leak of ioremapped memory
Browse files Browse the repository at this point in the history
cciss: fix leak of ioremapped memory
in cciss_pci_init error path.

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
  • Loading branch information
Stephen M. Cameron authored and Jens Axboe committed Aug 7, 2010
1 parent 4809d09 commit da55032
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions drivers/block/cciss.c
Original file line number Diff line number Diff line change
Expand Up @@ -4114,6 +4114,10 @@ static int __devinit cciss_pci_init(ctlr_info_t *c)
if (err)
goto err_out_free_res;
c->vaddr = remap_pci_mem(c->paddr, 0x250);
if (!c->vaddr) {
err = -ENOMEM;
goto err_out_free_res;
}
err = cciss_wait_for_board_ready(c);
if (err)
goto err_out_free_res;
Expand Down Expand Up @@ -4198,6 +4202,12 @@ static int __devinit cciss_pci_init(ctlr_info_t *c)
* Deliberately omit pci_disable_device(): it does something nasty to
* Smart Array controllers that pci_enable_device does not undo
*/
if (c->transtable)
iounmap(c->transtable);
if (c->cfgtable)
iounmap(c->cfgtable);
if (c->vaddr)
iounmap(c->vaddr);
pci_release_regions(c->pdev);
return err;
}
Expand Down Expand Up @@ -4745,6 +4755,8 @@ static void __devexit cciss_remove_one(struct pci_dev *pdev)
pci_disable_msi(hba[i]->pdev);
#endif /* CONFIG_PCI_MSI */

iounmap(hba[i]->transtable);
iounmap(hba[i]->cfgtable);
iounmap(hba[i]->vaddr);

pci_free_consistent(hba[i]->pdev, hba[i]->nr_cmds * sizeof(CommandList_struct),
Expand Down

0 comments on commit da55032

Please sign in to comment.