Skip to content

Commit

Permalink
pinctrl: use dev_info instead of pr_info in pinctrl_select_state_locked
Browse files Browse the repository at this point in the history
And remove superfluous brackets.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Richard Genoud authored and Linus Walleij committed Apr 3, 2013
1 parent 950707c commit da58751
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/pinctrl/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -956,17 +956,16 @@ static int pinctrl_select_state_locked(struct pinctrl *p,
break;
}

if (ret < 0) {
if (ret < 0)
goto unapply_new_state;
}
}

p->state = state;

return 0;

unapply_new_state:
pr_info("Error applying setting, reverse things back\n");
dev_err(p->dev, "Error applying setting, reverse things back\n");

/*
* If the loop stopped on the 1st entry, nothing has been enabled,
Expand Down

0 comments on commit da58751

Please sign in to comment.