Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 284062
b: refs/heads/master
c: aa4079c
h: refs/heads/master
v: v3
  • Loading branch information
Julia Lawall authored and Mark Brown committed Jan 2, 2012
1 parent 1701086 commit da5c6b4
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 29 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: cd0ff7eff08e7daeba278cf58392aac519edff60
refs/heads/master: aa4079c110133e5ed86895a07bffb20dd20ed40e
42 changes: 14 additions & 28 deletions trunk/sound/soc/au1x/psc-i2s.c
Original file line number Diff line number Diff line change
Expand Up @@ -295,33 +295,34 @@ static int __devinit au1xpsc_i2s_drvprobe(struct platform_device *pdev)
int ret;
struct au1xpsc_audio_data *wd;

wd = kzalloc(sizeof(struct au1xpsc_audio_data), GFP_KERNEL);
wd = devm_kzalloc(&pdev->dev, sizeof(struct au1xpsc_audio_data),
GFP_KERNEL);
if (!wd)
return -ENOMEM;

iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!iores) {
ret = -ENODEV;
goto out0;
}
if (!iores)
return -ENODEV;

ret = -EBUSY;
if (!request_mem_region(iores->start, resource_size(iores),
pdev->name))
goto out0;
if (!devm_request_mem_region(&pdev->dev, iores->start,
resource_size(iores),
pdev->name))
return -EBUSY;

wd->mmio = ioremap(iores->start, resource_size(iores));
wd->mmio = devm_ioremap(&pdev->dev, iores->start,
resource_size(iores));
if (!wd->mmio)
goto out1;
return -EBUSY;

dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0);
if (!dmares)
goto out2;
return -EBUSY;
wd->dmaids[SNDRV_PCM_STREAM_PLAYBACK] = dmares->start;

dmares = platform_get_resource(pdev, IORESOURCE_DMA, 1);
if (!dmares)
goto out2;
return -EBUSY;
wd->dmaids[SNDRV_PCM_STREAM_CAPTURE] = dmares->start;

/* preserve PSC clock source set up by platform (dev.platform_data
Expand Down Expand Up @@ -349,23 +350,12 @@ static int __devinit au1xpsc_i2s_drvprobe(struct platform_device *pdev)

platform_set_drvdata(pdev, wd);

ret = snd_soc_register_dai(&pdev->dev, &wd->dai_drv);
if (!ret)
return 0;

out2:
iounmap(wd->mmio);
out1:
release_mem_region(iores->start, resource_size(iores));
out0:
kfree(wd);
return ret;
return snd_soc_register_dai(&pdev->dev, &wd->dai_drv);
}

static int __devexit au1xpsc_i2s_drvremove(struct platform_device *pdev)
{
struct au1xpsc_audio_data *wd = platform_get_drvdata(pdev);
struct resource *r = platform_get_resource(pdev, IORESOURCE_MEM, 0);

snd_soc_unregister_dai(&pdev->dev);

Expand All @@ -374,10 +364,6 @@ static int __devexit au1xpsc_i2s_drvremove(struct platform_device *pdev)
au_writel(PSC_CTRL_DISABLE, PSC_CTRL(wd));
au_sync();

iounmap(wd->mmio);
release_mem_region(r->start, resource_size(r));
kfree(wd);

return 0;
}

Expand Down

0 comments on commit da5c6b4

Please sign in to comment.