Skip to content

Commit

Permalink
ath9k: change maximum software retransmission handling
Browse files Browse the repository at this point in the history
Instead of limiting a subframe to 10 A-MPDU software transmission attempts,
count hardware retransmissions as well and raise the limit a bit. That way
there will be fewer software retransmission attempts when traffic suffers
from lots of hardware retransmissions.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Felix Fietkau authored and John W. Linville committed Dec 15, 2011
1 parent 1478acb commit da64762
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/net/wireless/ath/ath9k/ath9k.h
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ struct ath_ant_comb {
#define DEFAULT_CACHELINE 32
#define ATH_REGCLASSIDS_MAX 10
#define ATH_CABQ_READY_TIME 80 /* % of beacon interval */
#define ATH_MAX_SW_RETRIES 10
#define ATH_MAX_SW_RETRIES 30
#define ATH_CHAN_MAX 255

#define ATH_TXPOWER_MAX 100 /* .5 dBm units */
Expand Down
15 changes: 12 additions & 3 deletions drivers/net/wireless/ath/ath9k/xmit.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,14 +264,17 @@ static void ath_tid_drain(struct ath_softc *sc, struct ath_txq *txq,
}

static void ath_tx_set_retry(struct ath_softc *sc, struct ath_txq *txq,
struct sk_buff *skb)
struct sk_buff *skb, int count)
{
struct ath_frame_info *fi = get_frame_info(skb);
struct ath_buf *bf = fi->bf;
struct ieee80211_hdr *hdr;
int prev = fi->retries;

TX_STAT_INC(txq->axq_qnum, a_retries);
if (fi->retries++ > 0)
fi->retries += count;

if (prev > 0)
return;

hdr = (struct ieee80211_hdr *)skb->data;
Expand Down Expand Up @@ -379,6 +382,7 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
int nframes;
u8 tidno;
bool flush = !!(ts->ts_status & ATH9K_TX_FLUSH);
int i, retries;

skb = bf->bf_mpdu;
hdr = (struct ieee80211_hdr *)skb->data;
Expand All @@ -387,6 +391,10 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,

memcpy(rates, tx_info->control.rates, sizeof(rates));

retries = ts->ts_longretry + 1;
for (i = 0; i < ts->ts_rateindex; i++)
retries += rates[i].count;

rcu_read_lock();

sta = ieee80211_find_sta_by_ifaddr(hw, hdr->addr1, hdr->addr2);
Expand Down Expand Up @@ -471,7 +479,8 @@ static void ath_tx_complete_aggr(struct ath_softc *sc, struct ath_txq *txq,
txpending = 1;
} else if (fi->retries < ATH_MAX_SW_RETRIES) {
if (txok || !an->sleeping)
ath_tx_set_retry(sc, txq, bf->bf_mpdu);
ath_tx_set_retry(sc, txq, bf->bf_mpdu,
retries);

txpending = 1;
} else {
Expand Down

0 comments on commit da64762

Please sign in to comment.