Skip to content

Commit

Permalink
IB/iser: Use more completion queues
Browse files Browse the repository at this point in the history
No reason to settle with four, can use the min between device max comp
vectors and number of cores.

Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
Sagi Grimberg authored and Roland Dreier committed Dec 16, 2014
1 parent 7e1fd4d commit da64bdb
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
4 changes: 1 addition & 3 deletions drivers/infiniband/ulp/iser/iscsi_iser.h
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,6 @@ struct iser_rx_desc {
char pad[ISER_RX_PAD_SIZE];
} __attribute__((packed));

#define ISER_MAX_CQ 4

struct iser_conn;
struct ib_conn;
struct iscsi_iser_task;
Expand Down Expand Up @@ -378,7 +376,7 @@ struct iser_device {
struct list_head ig_list;
int refcount;
int comps_used;
struct iser_comp comps[ISER_MAX_CQ];
struct iser_comp *comps;
int (*iser_alloc_rdma_reg_res)(struct ib_conn *ib_conn,
unsigned cmds_max);
void (*iser_free_rdma_reg_res)(struct ib_conn *ib_conn);
Expand Down
12 changes: 11 additions & 1 deletion drivers/infiniband/ulp/iser/iser_verbs.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,14 @@ static int iser_create_device_ib_res(struct iser_device *device)
return -1;
}

device->comps_used = min(ISER_MAX_CQ,
device->comps_used = min_t(int, num_online_cpus(),
device->ib_device->num_comp_vectors);

device->comps = kcalloc(device->comps_used, sizeof(*device->comps),
GFP_KERNEL);
if (!device->comps)
goto comps_err;

max_cqe = min(ISER_MAX_CQ_LEN, dev_attr->max_cqe);

iser_info("using %d CQs, device %s supports %d vectors max_cqe %d\n",
Expand Down Expand Up @@ -165,6 +170,8 @@ static int iser_create_device_ib_res(struct iser_device *device)
}
ib_dealloc_pd(device->pd);
pd_err:
kfree(device->comps);
comps_err:
iser_err("failed to allocate an IB resource\n");
return -1;
}
Expand All @@ -190,6 +197,9 @@ static void iser_free_device_ib_res(struct iser_device *device)
(void)ib_dereg_mr(device->mr);
(void)ib_dealloc_pd(device->pd);

kfree(device->comps);
device->comps = NULL;

device->mr = NULL;
device->pd = NULL;
}
Expand Down

0 comments on commit da64bdb

Please sign in to comment.