Skip to content

Commit

Permalink
ftrace: remove printks from irqsoff trace
Browse files Browse the repository at this point in the history
Printing out new max latencies was fine for the old RT tracer. But for
mainline it is a bit messy. We also need to test if the run queue
is locked before we can do the print. This means that we may not be
printing out latencies if the run queue is locked on another CPU.
This produces inconsistencies in the output.

This patch simply removes the print altogether.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Cc: pq@iki.fi
Cc: proski@gnu.org
Cc: sandmann@redhat.com
Cc: a.p.zijlstra@chello.nl
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Steven Rostedt authored and Thomas Gleixner committed May 26, 2008
1 parent 7e18d8e commit da89a7a
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions kernel/trace/trace_irqsoff.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,22 +165,6 @@ check_critical_timing(struct trace_array *tr,

update_max_tr_single(tr, current, cpu);

if (!runqueue_is_locked()) {
if (tracing_thresh) {
printk(KERN_INFO "(%16s-%-5d|#%d): %lu us critical"
" section violates %lu us threshold.\n",
current->comm, current->pid,
raw_smp_processor_id(),
latency, nsecs_to_usecs(tracing_thresh));
} else {
printk(KERN_INFO "(%16s-%-5d|#%d): new %lu us"
" maximum-latency critical section.\n",
current->comm, current->pid,
raw_smp_processor_id(),
latency);
}
}

max_sequence++;

out_unlock:
Expand Down

0 comments on commit da89a7a

Please sign in to comment.