Skip to content

Commit

Permalink
Input: aiptek - use only absolute misc reports
Browse files Browse the repository at this point in the history
To get an on - off reporting for proximity, absolute misc reports are
used. The mixture of absolute and relative reports is awkward

Signed-off-by: Rene van Paassen <rene.vanpaassen@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Rene van Paassen authored and Dmitry Torokhov committed Jul 10, 2007
1 parent 6125a40 commit da9fda4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/input/tablet/aiptek.c
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,9 @@ static const char *map_val_to_str(const struct aiptek_map *map, int val)
* Proximity. Why two events? I thought it interesting to know if the
* Proximity event occurred while the tablet was in absolute or relative
* mode.
* Update: REL_MISC proved not to be such a good idea. With REL_MISC you
* get an event transmitted each time. ABS_MISC works better, since it
* can be set and re-set. Thus, only using ABS_MISC from now on.
*
* Other tablets use the notion of a certain minimum stylus pressure
* to infer proximity. While that could have been done, that is yet
Expand Down Expand Up @@ -639,7 +642,7 @@ static void aiptek_irq(struct urb *urb)
aiptek->curSetting.wheel = AIPTEK_WHEEL_DISABLE;
}
}
input_report_rel(inputdev, REL_MISC, p | AIPTEK_REPORT_TOOL_MOUSE);
input_report_abs(inputdev, ABS_MISC, p | AIPTEK_REPORT_TOOL_MOUSE);
input_sync(inputdev);
}
}
Expand Down

0 comments on commit da9fda4

Please sign in to comment.