Skip to content

Commit

Permalink
trace: code style clean up
Browse files Browse the repository at this point in the history
Ingo Molnar suggested using goto logic to keep the indentation
down and to be able to remove the nasty line breaks. This actually
makes the code a bit more readable.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Steven Rostedt authored and Ingo Molnar committed Feb 5, 2009
1 parent 7be4215 commit dac7494
Showing 1 changed file with 15 additions and 14 deletions.
29 changes: 15 additions & 14 deletions kernel/trace/trace.c
Original file line number Diff line number Diff line change
Expand Up @@ -522,23 +522,24 @@ int register_tracer(struct tracer *type)
tracing_selftest_running = false;
mutex_unlock(&trace_types_lock);

if (!ret && default_bootup_tracer) {
if (!strncmp(default_bootup_tracer, type->name,
BOOTUP_TRACER_SIZE)) {
printk(KERN_INFO "Starting tracer '%s'\n",
type->name);
/* Do we want this tracer to start on bootup? */
tracing_set_tracer(type->name);
default_bootup_tracer = NULL;
/* disable other selftests, since this will break it. */
tracing_selftest_disabled = 1;
if (ret || !default_bootup_tracer)
goto out_unlock;

if (strncmp(default_bootup_tracer, type->name, BOOTUP_TRACER_SIZE))
goto out_unlock;

printk(KERN_INFO "Starting tracer '%s'\n", type->name);
/* Do we want this tracer to start on bootup? */
tracing_set_tracer(type->name);
default_bootup_tracer = NULL;
/* disable other selftests, since this will break it. */
tracing_selftest_disabled = 1;
#ifdef CONFIG_FTRACE_STARTUP_TEST
printk(KERN_INFO "Disabling FTRACE selftests due"
" to running tracer '%s'\n", type->name);
printk(KERN_INFO "Disabling FTRACE selftests due to running tracer '%s'\n",
type->name);
#endif
}
}

out_unlock:
lock_kernel();
return ret;
}
Expand Down

0 comments on commit dac7494

Please sign in to comment.