Skip to content

Commit

Permalink
sfc: Do not call netif_{stop,wake}_queue() before register_netdev
Browse files Browse the repository at this point in the history
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Steve Hodgson authored and Jeff Garzik committed Sep 3, 2008
1 parent f8b87c1 commit dacccc7
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/net/sfc/efx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,8 @@ static void efx_start_all(struct efx_nic *efx)
/* Mark the port as enabled so port reconfigurations can start, then
* restart the transmit interface early so the watchdog timer stops */
efx_start_port(efx);
efx_wake_queue(efx);
if (efx_dev_registered(efx))
efx_wake_queue(efx);

efx_for_each_channel(channel, efx)
efx_start_channel(channel);
Expand Down Expand Up @@ -1102,8 +1103,8 @@ static void efx_stop_all(struct efx_nic *efx)

/* Stop the kernel transmit interface late, so the watchdog
* timer isn't ticking over the flush */
efx_stop_queue(efx);
if (efx_dev_registered(efx)) {
efx_stop_queue(efx);
netif_tx_lock_bh(efx->net_dev);
netif_tx_unlock_bh(efx->net_dev);
}
Expand Down

0 comments on commit dacccc7

Please sign in to comment.