Skip to content

Commit

Permalink
[NET]: __alloc_pages() failures reported due to fragmentation
Browse files Browse the repository at this point in the history
We have seen a couple of __alloc_pages() failures due to
fragmentation, there is plenty of free memory but no large order pages
available.  I think the problem is in sock_alloc_send_pskb(), the
gfp_mask includes __GFP_REPEAT but its never used/passed to the page
allocator.  Shouldnt the gfp_mask be passed to alloc_skb() ?

Signed-off-by: Larry Woodman <lwoodman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Larry Woodman authored and David S. Miller committed Nov 5, 2006
1 parent 0f37c60 commit db38c17
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/core/sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,7 @@ static struct sk_buff *sock_alloc_send_pskb(struct sock *sk,
goto failure;

if (atomic_read(&sk->sk_wmem_alloc) < sk->sk_sndbuf) {
skb = alloc_skb(header_len, sk->sk_allocation);
skb = alloc_skb(header_len, gfp_mask);
if (skb) {
int npages;
int i;
Expand Down

0 comments on commit db38c17

Please sign in to comment.