---

yaml --- r: 288919 b: refs/heads/master c: 350a195 h: refs/heads/master i: 288917: 6892688 288915: 8191296 288911: 10b753f v: v3
git-mirror · Feb 9, 2012 · db8d757 · db8d757
1 parent eacfc74
commit db8d757
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 169c843afffcb328390ef39ff95227596d6f63c4
+refs/heads/master: 350a1955957d73352c043d0f948e3f28bb118c57
diff --git a/trunk/drivers/staging/android/logger.c b/trunk/drivers/staging/android/logger.c
@@ -330,6 +330,12 @@ static ssize_t do_write_log_from_user(struct logger_log *log,
 
 	if (count != len)
 		if (copy_from_user(log->buffer, buf + len, count - len))
+			/*
+			 * Note that by not updating w_off, this abandons the
+			 * portion of the new entry that *was* successfully
+			 * copied, just above.  This is intentional to avoid
+			 * message corruption from missing fragments.
+			 */
 			return -EFAULT;
 
 	log->w_off = logger_offset(log, log->w_off + count);