Skip to content

Commit

Permalink
dp83640: Make use of skb_queue_purge instead of reimplementing the code
Browse files Browse the repository at this point in the history
This change makes it so that dp83640_remove can use skb_queue_purge
instead of looping through itself to flush any entries out of the queue.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Duyck authored and David S. Miller committed Sep 8, 2014
1 parent eb84d6b commit db91b72
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/net/phy/dp83640.c
Original file line number Diff line number Diff line change
Expand Up @@ -1136,19 +1136,15 @@ static void dp83640_remove(struct phy_device *phydev)
struct dp83640_clock *clock;
struct list_head *this, *next;
struct dp83640_private *tmp, *dp83640 = phydev->priv;
struct sk_buff *skb;

if (phydev->addr == BROADCAST_ADDR)
return;

enable_status_frames(phydev, false);
cancel_work_sync(&dp83640->ts_work);

while ((skb = skb_dequeue(&dp83640->rx_queue)) != NULL)
kfree_skb(skb);

while ((skb = skb_dequeue(&dp83640->tx_queue)) != NULL)
kfree_skb(skb);
skb_queue_purge(&dp83640->rx_queue);
skb_queue_purge(&dp83640->tx_queue);

clock = dp83640_clock_get(dp83640->clock);

Expand Down

0 comments on commit db91b72

Please sign in to comment.