Skip to content

Commit

Permalink
net/mlx4_en: Use the correct netif lock on ndo_set_rx_mode
Browse files Browse the repository at this point in the history
The device multicast list is protected by netif_addr_lock_bh in the networking core, we should
use this locking practice in mlx4_en too.

Signed-off-by: Eugenia Emantayev <eugenia@mellanox.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
Reviewed-by: Yevgeny Petrilin <yevgenyp@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eugenia Emantayev authored and David S. Miller committed Jan 28, 2013
1 parent db0e7cb commit dbd501a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/mellanox/mlx4/en_netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -767,9 +767,9 @@ static void mlx4_en_do_set_multicast(struct work_struct *work)

/* Update multicast list - we cache all addresses so they won't
* change while HW is updated holding the command semaphor */
netif_tx_lock_bh(dev);
netif_addr_lock_bh(dev);
mlx4_en_cache_mclist(dev);
netif_tx_unlock_bh(dev);
netif_addr_unlock_bh(dev);
list_for_each_entry(mclist, &priv->mc_list, list) {
mcast_addr = mlx4_en_mac_to_u64(mclist->addr);
mlx4_SET_MCAST_FLTR(mdev->dev, priv->port,
Expand Down

0 comments on commit dbd501a

Please sign in to comment.