Skip to content

Commit

Permalink
USB: BKL removal: idmouse
Browse files Browse the repository at this point in the history
BKL was not needed at all. Removed without replacement.

Signed-off-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Oliver Neukum authored and Greg Kroah-Hartman committed Mar 2, 2010
1 parent 511e2d0 commit dbdae3b
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions drivers/usb/misc/idmouse.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
#include <linux/module.h>
#include <linux/completion.h>
#include <linux/mutex.h>
#include <linux/smp_lock.h>
#include <asm/uaccess.h>
#include <linux/usb.h>

Expand Down Expand Up @@ -227,20 +226,16 @@ static int idmouse_open(struct inode *inode, struct file *file)
struct usb_interface *interface;
int result;

lock_kernel();
/* get the interface from minor number and driver information */
interface = usb_find_interface (&idmouse_driver, iminor (inode));
if (!interface) {
unlock_kernel();
if (!interface)
return -ENODEV;
}

mutex_lock(&open_disc_mutex);
/* get the device information block from the interface */
dev = usb_get_intfdata(interface);
if (!dev) {
mutex_unlock(&open_disc_mutex);
unlock_kernel();
return -ENODEV;
}

Expand Down Expand Up @@ -277,7 +272,6 @@ static int idmouse_open(struct inode *inode, struct file *file)

/* unlock this device */
mutex_unlock(&dev->lock);
unlock_kernel();
return result;
}

Expand Down

0 comments on commit dbdae3b

Please sign in to comment.