Skip to content

Commit

Permalink
[PATCH] uml: local_irq_save, not local_save_flags
Browse files Browse the repository at this point in the history
The call to local_save_flags seems bogus since it is followed by
local_irq_restore, and it's intended to lock the list from concurrent
mconsole_interrupt invocations.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Paolo 'Blaisorblade' Giarrusso authored and Linus Torvalds committed Apr 11, 2006
1 parent 87276f7 commit dbdb4c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/um/drivers/mconsole_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ static void mc_work_proc(void *unused)
unsigned long flags;

while(!list_empty(&mc_requests)){
local_save_flags(flags);
local_irq_save(flags);
req = list_entry(mc_requests.next, struct mconsole_entry,
list);
list_del(&req->list);
Expand Down

0 comments on commit dbdb4c0

Please sign in to comment.